Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ubisoft-connect) Remove MailingListUrl to Ubisoft's Discord #401

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

Zoullx
Copy link
Contributor

@Zoullx Zoullx commented Jul 8, 2023

Ubisoft's forums have been closed and Discord is now used in place of those forums. This just updates the MailingListUrl to the Discord because since the forum link was broken it was causing the package to fail testing.

Copy link
Owner

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR, and I apologies for taking so long to be able to have a look at it. One thing before I can merge this.

automatic/ubisoft-connect/ubisoft-connect.nuspec Outdated Show resolved Hide resolved
@Zoullx
Copy link
Contributor Author

Zoullx commented Sep 5, 2023

Alright, MailingListUrl has been removed and committed, so this should take care of Ubisoft to auto update and pass validation testing again.

@Zoullx Zoullx requested a review from AdmiringWorm September 6, 2023 20:20
Copy link
Owner

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm changed the title Update MailingListUrl to Ubisoft's Discord (ubisoft-connect) Update MailingListUrl to Ubisoft's Discord Sep 25, 2023
@AdmiringWorm AdmiringWorm changed the title (ubisoft-connect) Update MailingListUrl to Ubisoft's Discord (ubisoft-connect) Remove MailingListUrl to Ubisoft's Discord Sep 25, 2023
@AdmiringWorm AdmiringWorm merged commit 6d9a84f into AdmiringWorm:master Sep 25, 2023
4 checks passed
@AdmiringWorm
Copy link
Owner

@Zoullx, your changes have been merged. Thanks for your contribution 👍

Apologies for taking so long to get this PR merged. I'll trigger a new version being pushed to the Community Repository immediately.

@Zoullx
Copy link
Contributor Author

Zoullx commented Sep 25, 2023

Awesome, thank you so much for getting to it. I'm just glad to have the package fixed for auto updates

@AdmiringWorm
Copy link
Owner

@all-contributors please add @Zoullx for docs

@allcontributors
Copy link
Contributor

@AdmiringWorm

I've put up a pull request to add @Zoullx! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants